-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing mkdocs generated github pages for etcd-druid documentation #909
Conversation
/test pull-etcd-druid-e2e-kind-nondistroless-etcd |
/test pull-etcd-druid-e2e-kind-nondistroless-etcd |
…g to help shreyas review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me except that now the !!! Note instead of > Note is not the same when rendered in a markdown viewer.
But as our goal is for the people to read through mkdocs, I'm guessing its fine to live with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please edit the commit message before merging to avoid "WIP" commit messages in the commit history of the repo. Thanks. |
/retest |
How to categorize this PR?
/area documentation
/kind enhancement
What this PR does / why we need it:
Following is done in this PR:
Which issue(s) this PR fixes:
Partially fixes #897
Special notes for your reviewer:
Once this PR is reviewed and merged there are some additional steps that needs to be done:
gh-pages
branch. To create such a branch do the following:gh-pages
branchTo view the docs you can see this in the fork https://unmarshall.github.io/etcd-druid/index.html
Release note: